Re: [PATCH v4 11/15] daemon: report connection from root-process

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 17, 2010, 04:43 UTC
Message-ID: <7v8w1x5sz7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTinXNPWaGj2BUaSOJypzv-Sqts-zEdG886oT2YJB@mail.gmail.com>

Erik Faye-Lund <kusmabite@gmail.com> writes:

Show 8 quoted lines

>> Hmm, loginfo() calls logreport() and adds the process information as
>> necessary to the output.  Wouldn't this patch give the pid information
>> twice?
>>
>
> Close, but not quite. logreport() reports the current PID, while this
> call to loginfo reports the PID of the child process. So two
> non-identical PIDs are reported.

I know that; I was questioning if that change to the log output is really what we want. I do not deeply care myself, but people with scripts that read logs might.

Show 11 quoted lines

>
> The output becomes something like this:
>
> [6408] [3868] Connection from [::1]:55801
> [3868] Extended attributes (16 bytes) exist <host=localhost>
> [3868] Request upload-pack for '/some-repo.git'
> [3868] '/some-repo.git' does not appear to be a git repository
> [6408] [1876] Connection from [::1]:57311
> [1876] Extended attributes (16 bytes) exist <host=localhost>
> [1876] Request upload-pack for '/some-repo.git'
> [1876] '/some-repo.git' does not appear to be a git repository