git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] commit: show abbreviated sha for commits with empty diffs

From
Tay Ray Chuan <rctay89@gmail.com>
Date
May 26, 2010, 05:39 UTC
Message-ID
<AANLkTinio71lh1y65IW7FKuVFI3PKPPyGc8LNTOT6yqt@mail.gmail.com>
In-Reply-To
<AANLkTik_R4U3SvUwLR1nFZhszhmVC8SCmp0JhjGFbUsO@mail.gmail.com>
Hi,
On Wed, May 26, 2010 at 1:37 PM, Tay Ray Chuan <rctay89@gmail.com> wrote:
Show 15 quoted lines
> Hi,
>
> On Wed, May 26, 2010 at 1:07 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> The fix itself might be trivial, but the series seems to break 7502.20
>> and 7502.22
>
> I tested this patch series on top of:
>
>  - efd1311 (Merge branch 'jn/shortlog' into next), which contains
>   c197702 (pretty: Respect --abbrev option), the first offending commit
>   to print un-abbreviated SHA-1s.
>
>  - b26ba11, the recent 'next'.
>
> It both cases, #20 and #22 passed fine.

My apologies - I've already squashed in a fix to address that locally and I haven't sent that out yet.

-- 
Cheers,
Ray Chuan
Previous: Tay Ray ChuanNext: Junio C Hamano
Message 7 of 17 in “commit: fix abbrev-sha regression”
  1. 0/3 commit: fix abbrev-sha regressionTay Ray Chuan, May 24, 2010
  2. 1/3 t7502-commit: add tests for summary outputTay Ray Chuan, May 24, 2010
  3. 2/3 t7502-commit: add summary output tests for empty and merge commitsTay Ray Chuan, May 24, 2010
  4. 3/3 commit: show abbreviated sha for commits with empty diffsTay Ray Chuan, May 24, 2010
  5. Junio C HamanoMay 26, 2010
  6. Tay Ray ChuanMay 26, 2010
  7. Tay Ray ChuanMay 26, 2010
  8. Junio C HamanoMay 26, 2010
  9. Tay Ray ChuanMay 26, 2010
  10. 0/3 commit: fix abbrev-sha regressionTay Ray Chuan, May 27, 2010
  11. 1/3 t7502-commit: add tests for summary outputTay Ray Chuan, May 27, 2010
  12. 2/3 t7502-commit: add summary output tests for empty and merge commitsTay Ray Chuan, May 27, 2010
  13. 3/3 commit::print_summary(): set rev_info.always_show_header to 1Tay Ray Chuan, May 27, 2010
  14. Junio C HamanoMay 29, 2010
  15. Tay Ray ChuanMay 29, 2010
  16. 3/3 commit::print_summary(): don't use format_commit_message()Tay Ray Chuan, Jun 12, 2010
  17. Will PalmerMay 27, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.