Re: [PATCH 3/3] commit: show abbreviated sha for commits with empty diffs

From: Tay Ray Chuan <rctay89@gmail.com>
Date: May 26, 2010, 05:37 UTC
Message-ID: <AANLkTik_R4U3SvUwLR1nFZhszhmVC8SCmp0JhjGFbUsO@mail.gmail.com>
In-Reply-To: <7viq6bqmid.fsf@alter.siamese.dyndns.org>

Hi,

On Wed, May 26, 2010 at 1:07 PM, Junio C Hamano <gitster@pobox.com> wrote:

> The fix itself might be trivial, but the series seems to break 7502.20
> and 7502.22

I tested this patch series on top of:

 - efd1311 (Merge branch 'jn/shortlog' into next), which contains
   c197702 (pretty: Respect --abbrev option), the first offending commit
   to print un-abbreviated SHA-1s.

 - b26ba11, the recent 'next'.

It both cases, #20 and #22 passed fine.

Also, I outlined another possible fix in the cover letter to this series:

  1274694452-4200-1-git-send-email-rctay89@gmail.com
  http://thread.gmane.org/gmane.comp.version-control.git/147619

I find the alternative fix a bit more precise; I'd appreciate your comments, if you get the chance.

-- 
Cheers,
Ray Chuan