Re: [PATCH 2/3] t7502-commit: add summary output tests for empty and merge commits

From: Tay Ray Chuan <rctay89@gmail.com>
Date: May 26, 2010, 05:19 UTC
Message-ID: <AANLkTikuukaZNVY8ikn3v1zdzGHUDLBC55fGih7Dgs7L@mail.gmail.com>
In-Reply-To: <7vvdabp7xa.fsf@alter.siamese.dyndns.org>

Hi,

On Wed, May 26, 2010 at 1:07 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 30 quoted lines

> Tay Ray Chuan <rctay89@gmail.com> writes:
>
>> After c197702 (pretty: Respect --abbrev option), non-abbreviated hashes
>> began to appear, leading to failures for these tests.
>>
>> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
>> ---
>>  t/t7502-commit.sh |   29 +++++++++++++++++++++++++++--
>>  1 files changed, 27 insertions(+), 2 deletions(-)
>>
>> diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh
>> index 589e8e6..8a4a277 100755
>> --- a/t/t7502-commit.sh
>> +++ b/t/t7502-commit.sh
>> @@ -4,10 +4,10 @@ test_description='git commit porcelain-ish'
>>
>>  . ./test-lib.sh
>>
>> -# Arguments: [<prefix] [<commit message>]
>> +# Arguments: [<prefix] [<commit message>] [<commit options>]
>>  check_summary_oneline() {
>>       test_tick &&
>> -     git commit -m "$2" | head -1 > act &&
>> +     echo "$3" | xargs git commit -m "$2" | head -1 > act &&
>
> Why do you have to fork xargs?  Wouldn't/shouldn't
>
>    git commit ${3+"$3"} -m "$2"
>
> work?

It would. Blame it on my poor shell-fu. :)

-- 
Cheers,
Ray Chuan