git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t1501: avoid bashisms

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Dec 25, 2010, 14:29 UTC
Message-ID
<AANLkTinhrBf14446rJBZSYWTSH6sxOchMcgBsrq8DoLO@mail.gmail.com>
In-Reply-To
<m2aajudjqt.fsf@whitebox.home>
2010/12/25 Andreas Schwab <schwab@linux-m68k.org>:
Show 9 quoted lines
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> @@ -322,7 +322,10 @@ test_expect_success 'git grep' '
>>  test_expect_success 'git commit' '
>>       (
>>               cd repo.git &&
>> -             GIT_DIR=. GIT_WORK_TREE=work git commit -a -m done
>
> In which way is that not portable?
I admit that I rarely leave bash, so I'll quote Johannes answer [1]

-- 8< -- Sure, it is (bashisms). This:

   GIT_DIR="$TRASH_DIRECTORY/2/.git" test_repo 2/sub

does not work the same way in all shells when test_repo is a shell function. You have to export GIT_DIR explicitly before the function call. (But since in this case, test_repo invokes its own subshell anyway, you better do it in the function.) -- 8< --

[1] http://article.gmane.org/gmane.comp.version-control.git/162207
-- 
Duy
Previous: Andreas SchwabNext: Nguyen Thai Ngoc Duy
Message 7 of 9 in “t1501: avoid bashisms”
  1. 1/2 t1501: avoid bashismsNguyễn Thái Ngọc Duy, Dec 25, 2010
  2. 2/2 setup_work_tree: adjust relative $GIT_WORK_TREE after moving cwdNguyễn Thái Ngọc Duy, Dec 25, 2010
  3. setup_work_tree: adjust relative $GIT_WORK_TREE after moving cwdNguyễn Thái Ngọc Duy, Dec 26, 2010
  4. setup_explicit_git_dir: adjust relative $GIT_WORK_TREE after moving cwdNguyễn Thái Ngọc Duy, Dec 26, 2010
  5. setup_work_tree: adjust relative $GIT_WORK_TREE after moving cwdNguyễn Thái Ngọc Duy, Dec 27, 2010
  6. Andreas SchwabDec 25, 2010
  7. Nguyen Thai Ngoc DuyDec 25, 2010
  8. Nguyen Thai Ngoc DuyDec 25, 2010
  9. Junio C HamanoDec 26, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.