Re: [PATCH 1/2] t1501: avoid bashisms

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Dec 25, 2010, 14:44 UTC
Message-ID: <AANLkTi=fCa4a-POoMWqnraFjz28-Ko4Yp0fcar+d7AsE@mail.gmail.com>
In-Reply-To: <AANLkTinhrBf14446rJBZSYWTSH6sxOchMcgBsrq8DoLO@mail.gmail.com>

On Sat, Dec 25, 2010 at 9:29 PM, Nguyen Thai Ngoc Duy <pclouds@gmail.com> wrote:

Show 20 quoted lines

> 2010/12/25 Andreas Schwab <schwab@linux-m68k.org>:
>> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>>
>>> @@ -322,7 +322,10 @@ test_expect_success 'git grep' '
>>>  test_expect_success 'git commit' '
>>>       (
>>>               cd repo.git &&
>>> -             GIT_DIR=. GIT_WORK_TREE=work git commit -a -m done
>>
>> In which way is that not portable?
>
> I admit that I rarely leave bash, so I'll quote Johannes answer [1]
>
> -- 8< --
> Sure, it is (bashisms). This:
>
>   GIT_DIR="$TRASH_DIRECTORY/2/.git" test_repo 2/sub
>
> does not work the same way in all shells when test_repo is a shell
> function. You have to export GIT_DIR explicitly before the function call.

Hmm.. I misread it. That's only for shell _functions_. [1] says variable assignments for simple commands are actually exported.

Junio, please don't pick up this patch.

[1] http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html

-- 
Duy