From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Sat, 25 Dec 2010 14:29:20 GMT
Subject: Re: [PATCH 1/2] t1501: avoid bashisms
Message-ID: <AANLkTinhrBf14446rJBZSYWTSH6sxOchMcgBsrq8DoLO@mail.gmail.com>
In-Reply-To: <m2aajudjqt.fsf@whitebox.home>

2010/12/25 Andreas Schwab <schwab@linux-m68k.org>:
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> @@ -322,7 +322,10 @@ test_expect_success 'git grep' '
>>  test_expect_success 'git commit' '
>>       (
>>               cd repo.git &&
>> -             GIT_DIR=. GIT_WORK_TREE=work git commit -a -m done
>
> In which way is that not portable?

I admit that I rarely leave bash, so I'll quote Johannes answer [1]

-- 8< --
Sure, it is (bashisms). This:

   GIT_DIR="$TRASH_DIRECTORY/2/.git" test_repo 2/sub

does not work the same way in all shells when test_repo is a shell
function. You have to export GIT_DIR explicitly before the function call.
(But since in this case, test_repo invokes its own subshell anyway, you
better do it in the function.)
-- 8< --

[1] http://article.gmane.org/gmane.comp.version-control.git/162207
-- 
Duy