git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] test-lib: clean up trash* directories on SIGINT

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jul 12, 2010, 05:42 UTC
Message-ID
<AANLkTindliEmS2XhH8B1dUyo-v-CzpLQBqZakOaNnARW@mail.gmail.com>
In-Reply-To
<alpine.LFD.2.00.1007112327150.10598@xanadu.home>
On Mon, Jul 12, 2010 at 03:32, Nicolas Pitre <nico@fluxnic.net> wrote:
Show 8 quoted lines
> On Sun, 11 Jul 2010, Ævar Arnfjörð Bjarmason wrote:
>
>> Is there any reason not to remove trash directories on SIGINT? It's
>> annoying that trash directories are left when I cancel a test run.
>
> What about tests that would fail due to some infinite loop?  The test
> would never complete until you manually interrupt it, and in that case
> the trash directory content might be valuable.

Unless that's due to some unreproducable heisenbug you could get the trash directory by running the test with --debug.

> You may do 'make clean' in the test directory to clean it.

I know, but I think not cleaning them up on SIGINT is a misfeature. These trash directories are explicitly temporary, and should be cleaned up as the shell exists.

Previous: Nicolas PitreNext: Jonathan Nieder
Message 4 of 7 in “test-lib: clean up trash* directories on SIGINT”
  1. test-lib: clean up trash* directories on SIGINTÆvar Arnfjörð Bjarmason, Jul 11, 2010
  2. Andreas SchwabJul 11, 2010
  3. Nicolas PitreJul 12, 2010
  4. Ævar Arnfjörð BjarmasonJul 12, 2010
  5. Jonathan NiederJul 12, 2010
  6. Ævar Arnfjörð BjarmasonJul 12, 2010
  7. Jonathan NiederJul 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.