From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mon, 12 Jul 2010 05:42:54 GMT
Subject: Re: [PATCH/RFC] test-lib: clean up trash* directories on SIGINT
Message-ID: <AANLkTindliEmS2XhH8B1dUyo-v-CzpLQBqZakOaNnARW@mail.gmail.com>
In-Reply-To: <alpine.LFD.2.00.1007112327150.10598@xanadu.home>

On Mon, Jul 12, 2010 at 03:32, Nicolas Pitre <nico@fluxnic.net> wrote:
> On Sun, 11 Jul 2010, Ævar Arnfjörð Bjarmason wrote:
>
>> Is there any reason not to remove trash directories on SIGINT? It's
>> annoying that trash directories are left when I cancel a test run.
>
> What about tests that would fail due to some infinite loop?  The test
> would never complete until you manually interrupt it, and in that case
> the trash directory content might be valuable.

Unless that's due to some unreproducable heisenbug you could get the
trash directory by running the test with --debug.

> You may do 'make clean' in the test directory to clean it.

I know, but I think not cleaning them up on SIGINT is a
misfeature. These trash directories are explicitly temporary, and
should be cleaned up as the shell exists.