git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] test-lib: clean up trash* directories on SIGINT

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jul 12, 2010, 06:16 UTC
Message-ID
<20100712061608.GA6140@burratino>
In-Reply-To
<AANLkTindliEmS2XhH8B1dUyo-v-CzpLQBqZakOaNnARW@mail.gmail.com>
Hi Ævar,
Ævar Arnfjörð Bjarmason wrote:
> Unless that's due to some unreproducable heisenbug you could get the
> trash directory by running the test with --debug.

So what should I do after noticing a heisenbug? I guess I can suspend with ^Z, but I would prefer not to have to train my fingers away from ^C.

> These trash directories are explicitly temporary, and
> should be cleaned up as the shell exists.

When tests learned to remove the trash directory in test_done in v1.6.1-rc1~336^2~1 (Enable parallel tests, 2008-08-08), that was not the rationale; it was rather to avoid too many trash directories piling up. If a test exits by mistake with ‘exit’ or fails with ‘-i’, the one or two scratch directories involved are still kept for debugging.

So you can see why a person would be reluctant to change this for aesthetic reasons only.

Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 5 of 7 in “test-lib: clean up trash* directories on SIGINT”
  1. test-lib: clean up trash* directories on SIGINTÆvar Arnfjörð Bjarmason, Jul 11, 2010
  2. Andreas SchwabJul 11, 2010
  3. Nicolas PitreJul 12, 2010
  4. Ævar Arnfjörð BjarmasonJul 12, 2010
  5. Jonathan NiederJul 12, 2010
  6. Ævar Arnfjörð BjarmasonJul 12, 2010
  7. Jonathan NiederJul 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.