git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/3] fetch-pack: use args.shallow to detect shallow clone instead of args.depth

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Aug 24, 2010, 22:14 UTC
Message-ID
<AANLkTinWWweV43NP34iFXKVcyyu7uiovsDQxNKmdD0wL@mail.gmail.com>
In-Reply-To
<7vlj7wx99v.fsf@alter.siamese.dyndns.org>
On Wed, Aug 25, 2010 at 2:31 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> ---
>
> Isn't there any rationale for this change?  "args.depth > 0 does not
> necessarily mean we are in a shallow clone situation, because ..." or
> "using args.depth > 0 to check if we are in a shallow clone breaks under
> such and such conditions and here is a test case to reproduce the bug"?

.. because args.depth=0 is now also a shallow clone situation, i.e. a valid depth too.

-- 
Duy
Previous: Junio C HamanoNext: Nguyễn Thái Ngọc Duy
Message 4 of 11 in “clone: warn users --depth is ignored in local clones”
  1. 1/3 clone: warn users --depth is ignored in local clonesNguyễn Thái Ngọc Duy, Aug 23, 2010
  2. 2/3 fetch-pack: use args.shallow to detect shallow clone instead of args.depthNguyễn Thái Ngọc Duy, Aug 23, 2010
  3. Junio C HamanoAug 24, 2010
  4. Nguyen Thai Ngoc DuyAug 24, 2010
  5. 3/3 {fetch,upload}-pack: allow --depth=0 for infinite depthNguyễn Thái Ngọc Duy, Aug 23, 2010
  6. Jeff KingAug 24, 2010
  7. Junio C HamanoAug 24, 2010
  8. Jeff KingAug 24, 2010
  9. Nguyen Thai Ngoc DuyAug 24, 2010
  10. Jonathan NiederAug 24, 2010
  11. Nguyen Thai Ngoc DuyAug 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.