From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Tue, 24 Aug 2010 22:14:20 GMT
Subject: Re: [PATCH v2 2/3] fetch-pack: use args.shallow to detect shallow clone instead of args.depth
Message-ID: <AANLkTinWWweV43NP34iFXKVcyyu7uiovsDQxNKmdD0wL@mail.gmail.com>
In-Reply-To: <7vlj7wx99v.fsf@alter.siamese.dyndns.org>

On Wed, Aug 25, 2010 at 2:31 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> ---
>
> Isn't there any rationale for this change?  "args.depth > 0 does not
> necessarily mean we are in a shallow clone situation, because ..." or
> "using args.depth > 0 to check if we are in a shallow clone breaks under
> such and such conditions and here is a test case to reproduce the bug"?

.. because args.depth=0 is now also a shallow clone situation, i.e. a
valid depth too.
-- 
Duy