git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/3] {fetch,upload}-pack: allow --depth=0 for infinite depth

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Aug 24, 2010, 22:12 UTC
Message-ID
<AANLkTimqwXmRYVZLkYtGLd5=e1B0hKKePA0XzOYPrifd@mail.gmail.com>
In-Reply-To
<20100824135341.GA6457@coredump.intra.peff.net>
On Tue, Aug 24, 2010 at 11:53 PM, Jeff King <peff@peff.net> wrote:
Show 9 quoted lines
> On Mon, Aug 23, 2010 at 10:08:24PM +1000, Nguyễn Thái Ngọc Duy wrote:
>
>> Users can do --depth=2147483648 for infinite depth now. It just looks
>> ugly. So make "0" special (i.e. infinite depth) at plumbing/protocol
>> level.
>
> What happens if I connect to an older server? Shouldn't "I understand
> depth=0 is infinite" be a server capability, and we hack around it by
> sending depth=2^32-1 when we have a modern client but an older server?

Older servers won't accept depth=0, dying with "Invalid deepen" message. I don't really want to send a large number as a workaround, it just does not feel safe. Users can either play around with --depth=2^32-1, or upgrade servers.

And in case of modern server and old client, old fetch-pack would never send "deepen 0", so it's safe too, at least for current fetch-pack.

-- 
Duy
Previous: Jeff KingNext: Jonathan Nieder
Message 9 of 11 in “clone: warn users --depth is ignored in local clones”
  1. 1/3 clone: warn users --depth is ignored in local clonesNguyễn Thái Ngọc Duy, Aug 23, 2010
  2. 2/3 fetch-pack: use args.shallow to detect shallow clone instead of args.depthNguyễn Thái Ngọc Duy, Aug 23, 2010
  3. Junio C HamanoAug 24, 2010
  4. Nguyen Thai Ngoc DuyAug 24, 2010
  5. 3/3 {fetch,upload}-pack: allow --depth=0 for infinite depthNguyễn Thái Ngọc Duy, Aug 23, 2010
  6. Jeff KingAug 24, 2010
  7. Junio C HamanoAug 24, 2010
  8. Jeff KingAug 24, 2010
  9. Nguyen Thai Ngoc DuyAug 24, 2010
  10. Jonathan NiederAug 24, 2010
  11. Nguyen Thai Ngoc DuyAug 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.