Re: [PATCH 9/9] Add a sample user for the svndump library

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Jun 24, 2010, 20:42 UTC
Message-ID: <AANLkTinSbQbT1tmKIiWnZnX52mJEZOlf9xCV1ENUGFT_@mail.gmail.com>
In-Reply-To: <20100624203041.GA2262@burratino>

Hi again,

Jonathan Nieder wrote:

> Turn off persistence until it is ready.  At that point, we will need
> to access the target git repo anyway, so we can keep extra metadata in
> the .git directory.

Unfortunately, turning off persistence isn't so easy now because the branch has been merged into master now, and it's difficult to sort out just the commits that correspond to persistence and rebase. Yes, the remote helper can use the .git directory, but I thought we wanted to keep this in contrib/ even after the remote helper is merged?

Show 9 quoted lines

> See commit 74f2b2a.
>
> Summary: this produces the
>
>    CC foo.o
>
> lines.  The idea is that long command lines distract from what is more
> important, which is the compiler output.  The behavior can be turned
> off with “make V=1” or “make -s”.

Ah. Black magic :)

> Maybe the file should get a simpler license?  e.g.:
>
>  This file is in the public domain.
>  You may freely use, modify, distribute, and relicense it.

Yes, I like this.

> Sounds reasonable.  Care to suggest wording?

Something along "REPO is a path to a Subversion repository mirrored on the local disk. Remote Subversion repositories can be mirrored on local disk using the `svnsync` command."

> Do version 3 dumpfiles fail?

Yes, they do. We aren't parsing the extra headers anywhere, and deltified dumps aren't supported.

-- Ram