Re: [PATCH 3/9] Add memory pool library
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Jun 24, 2010, 19:37 UTC
- Message-ID
- <AANLkTikNV0m5E7982wY5wdtcMstpfKKMX4MdZvdhqhOb@mail.gmail.com>
- In-Reply-To
- <20100624185521.GB1848@burratino>
Hi Jonathan,
Jonathan Nieder wrote:
> If we used templates instead of macros, a smart compiler would notice > which functions are _never_ used. But sticking to C, I think it is > fine to rely on humans checking by hand for now. (FWIW no obj_pool > functions are unused at the moment.)
> Filling out such a list for each caller sounds to me like more trouble > than it’s worth.
Okay, I have an idea. We'll document it as a comment so people will be able to see which exact functions were unused in this import. The following functions are unused: blob_init, blob_offset, blob_commit, commit_free, commit_offset, dir_free, node_init, node_commit, string_offset, tree_first, tree_next, tree_remove, log_init, log_offset, and log_commit.
-- Ram