Re: [PATCH 3/9] Add memory pool library

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jun 24, 2010, 18:55 UTC
Message-ID: <20100624185521.GB1848@burratino>
In-Reply-To: <AANLkTilItX_xbbpX9mfKg0Dfx6ThzYuVsBu25C_-fJ6W@mail.gmail.com>

Hi Ram,

Ramkumar Ramachandra wrote:

> By marking all the generated functions MAYBE_UNUSED, we're
> actually suppressing more warnings than intended. Maybe we can avoid
> it and somehow find a way to mark only those functions that are really
> unused?

If we used templates instead of macros, a smart compiler would notice which functions are _never_ used. But sticking to C, I think it is fine to rely on humans checking by hand for now. (FWIW no obj_pool functions are unused at the moment.)

I tried leaving out the MAYBE_UNUSED for foo_init() before I realized that calling it is optional.

> Perhaps an extra parameter in obj_pool_gen?

Filling out such a list for each caller sounds to me like more trouble than it’s worth.

Jonathan