Re: [PATCHv5 15/16] Add missing &&'s throughout the testsuite
On Sun, Oct 3, 2010 at 8:46 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 21 quoted lines
>> --- a/t/t1509-root-worktree.sh
>> +++ b/t/t1509-root-worktree.sh
>> @@ -232,8 +232,8 @@ say "auto bare gitdir"
>>
>> # DESTROYYYYY!!!!!
>> test_expect_success 'setup' '
>> - rm -rf /refs /objects /info /hooks
>> - rm /*
>> + rm -rf /refs /objects /info /hooks &&
>> + rm /* &&
>
> I'm worried that this would fail:
>
> $ mkdir foo
> $ cd foo
> $ >bar
> $ mkdir baz
> $ rm *
> rm: cannot remove `baz': Is a directory
> $ echo $?
> 1
How about replacing the two rm commands with a simple 'rm -rf /*'?
Show 6 quoted lines
> test_expect_success 'did not use upload-pack service' '
> ! grep '/git-upload-pack' <"$HTTPD_ROOT_PATH"/access.log
> '
>
> This way, (like before) one would get to see the git-upload-pack lines
> when the test fails while running with -v.
Show 7 quoted lines
>> - ln -s docs/manual.txt src/part4.c
>> + ln -s docs/manual.txt src/part4.c &&
>> git clean &&
>> test -f Makefile &&
>> test -f README &&
>
> Missing SYMLINKS prereq?
Elijah Newren <newren@gmail.com>