From: Elijah Newren <newren@gmail.com>
Date: Sun, 03 Oct 2010 19:39:45 GMT
Subject: Re: [PATCHv5 15/16] Add missing &&'s throughout the testsuite
Message-ID: <AANLkTin3vtqGJDC4hrmKpFZ6e+Sw5OP15QPjO16cxgkx@mail.gmail.com>
In-Reply-To: <20101003144650.GE17084@burratino>

On Sun, Oct 3, 2010 at 8:46 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> --- a/t/t1509-root-worktree.sh
>> +++ b/t/t1509-root-worktree.sh
>> @@ -232,8 +232,8 @@ say "auto bare gitdir"
>>
>>  # DESTROYYYYY!!!!!
>>  test_expect_success 'setup' '
>> -     rm -rf /refs /objects /info /hooks
>> -     rm /*
>> +     rm -rf /refs /objects /info /hooks &&
>> +     rm /* &&
>
> I'm worried that this would fail:
>
>        $ mkdir foo
>        $ cd foo
>        $ >bar
>        $ mkdir baz
>        $ rm *
>        rm: cannot remove `baz': Is a directory
>        $ echo $?
>        1

How about replacing the two rm commands with a simple 'rm -rf /*'?

>        test_expect_success 'did not use upload-pack service' '
>                ! grep '/git-upload-pack' <"$HTTPD_ROOT_PATH"/access.log
>        '
>
> This way, (like before) one would get to see the git-upload-pack lines
> when the test fails while running with -v.

Make sense.

>> -     ln -s docs/manual.txt src/part4.c
>> +     ln -s docs/manual.txt src/part4.c &&
>>       git clean &&
>>       test -f Makefile &&
>>       test -f README &&
>
> Missing SYMLINKS prereq?

Indeed.