git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv5 13/16] t7601 (merge-pull-config): add missing &&

From
Elijah Newren <newren@gmail.com>
Date
Oct 3, 2010, 05:10 UTC
Message-ID
<1286082644-31595-14-git-send-email-newren@gmail.com>
In-Reply-To
<1286082644-31595-1-git-send-email-newren@gmail.com>

Also prefix several relevant git merge commands with 'test_must_fail' to keep the tests passing.

Acked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
---
 t/t7601-merge-pull-config.sh |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/t/t7601-merge-pull-config.sh b/t/t7601-merge-pull-config.sh
index 7ba94ea..b44b293 100755
--- a/t/t7601-merge-pull-config.sh
+++ b/t/t7601-merge-pull-config.sh
@@ -114,13 +114,13 @@ test_expect_success 'setup conflicted merge' '
 test_expect_success 'merge picks up the best result' '
 	git config --unset-all pull.twohead &&
 	git reset --hard c5 &&
-	git merge -s resolve c6
+	test_must_fail git merge -s resolve c6 &&
 	resolve_count=$(conflict_count) &&
 	git reset --hard c5 &&
-	git merge -s recursive c6
+	test_must_fail git merge -s recursive c6 &&
 	recursive_count=$(conflict_count) &&
 	git reset --hard c5 &&
-	git merge -s recursive -s resolve c6
+	test_must_fail git merge -s recursive -s resolve c6 &&
 	auto_count=$(conflict_count) &&
 	test $auto_count = $recursive_count &&
 	test $auto_count != $resolve_count
@@ -129,13 +129,13 @@ test_expect_success 'merge picks up the best result' '
 test_expect_success 'merge picks up the best result (from config)' '
 	git config pull.twohead "recursive resolve" &&
 	git reset --hard c5 &&
-	git merge -s resolve c6
+	test_must_fail git merge -s resolve c6 &&
 	resolve_count=$(conflict_count) &&
 	git reset --hard c5 &&
-	git merge -s recursive c6
+	test_must_fail git merge -s recursive c6 &&
 	recursive_count=$(conflict_count) &&
 	git reset --hard c5 &&
-	git merge c6
+	test_must_fail git merge c6 &&
 	auto_count=$(conflict_count) &&
 	test $auto_count = $recursive_count &&
 	test $auto_count != $resolve_count
-- 
1.7.3.1.66.gab790
Previous: Elijah NewrenNext: Elijah Newren
Message 22 of 32 in “[PATCHv5 00/16] Add missing &&'s in the testsuite”
  1. Elijah NewrenOct 3, 2010
  2. 01/16 test-lib: make test_expect_code a test commandElijah Newren, Oct 3, 2010
  3. Jonathan NiederOct 3, 2010
  4. Elijah NewrenOct 3, 2010
  5. 02/16 t3020 (ls-files-error-unmatch): remove stray '1' from end of fileElijah Newren, Oct 3, 2010
  6. 03/16 t4017 (diff-retval): replace manual exit code check with test_expect_codeElijah Newren, Oct 3, 2010
  7. Jonathan NiederOct 3, 2010
  8. Elijah NewrenOct 3, 2010
  9. 04/16 t100[12] (read-tree-m-2way, read_tree_m_u_2way): add missing &&Elijah Newren, Oct 3, 2010
  10. 05/16 t4002 (diff-basic): use test_might_fail for commands that might failElijah Newren, Oct 3, 2010
  11. 06/16 t4202 (log): Replace '<git-command> || :' with test_might_failElijah Newren, Oct 3, 2010
  12. 07/16 t3600 (rm): add lots of missing &&Elijah Newren, Oct 3, 2010
  13. Jonathan NiederOct 3, 2010
  14. Elijah NewrenOct 3, 2010
  15. 08/16 t4019 (diff-wserror): add lots of missing &&Elijah Newren, Oct 3, 2010
  16. Jonathan NiederOct 3, 2010
  17. Ævar Arnfjörð BjarmasonOct 4, 2010
  18. 09/16 t4026 (color): remove unneeded and unchained commandElijah Newren, Oct 3, 2010
  19. 10/16 t5602 (clone-remote-exec): add missing &&Elijah Newren, Oct 3, 2010
  20. 11/16 t6016 (rev-list-graph-simplify-history): add missing &&Elijah Newren, Oct 3, 2010
  21. 12/16 t7001 (mv): add missing &&Elijah Newren, Oct 3, 2010
  22. 13/16 t7601 (merge-pull-config): add missing &&Elijah Newren, Oct 3, 2010
  23. 14/16 t7800 (difftool): add missing &&Elijah Newren, Oct 3, 2010
  24. 15/16 Add missing &&'s throughout the testsuiteElijah Newren, Oct 3, 2010
  25. Jonathan NiederOct 3, 2010
  26. Elijah NewrenOct 3, 2010
  27. Junio C HamanoOct 3, 2010
  28. 16/16 Introduce portable_unset and use it to ensure proper && chainingElijah Newren, Oct 3, 2010
  29. Jonathan NiederOct 3, 2010
  30. Elijah NewrenOct 3, 2010
  31. Junio C HamanoOct 3, 2010
  32. Jonathan NiederOct 3, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.