git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 002/160] Makefile: Set NO_GETTEXT=YesPlease on Windows & MinGW

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Nov 15, 2010, 10:35 UTC
Message-ID
<AANLkTin2sMUBtS_WgVX39ngRGrWRLf=Z_+UhGNorP6VH@mail.gmail.com>
In-Reply-To
<1289747245-23263-2-git-send-email-avarab@gmail.com>
(msysgit mailing list CC'ed)

On Sun, Nov 14, 2010 at 4:07 PM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 7 quoted lines
> Change the Windows and MinGW build defaults to not build the gettext
> tools by default. Gettext hasn't yet been ported to the default
> environments on those systems, although Erik Faye-Lund is working on
> MinGW support.
>
> Reported-by: Johannes Sixt <j6t@kdbg.org>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

I don't think this is exactly what Hannes reported; IIRC he reported that setting NO_GETTEXT wasn't sufficient to get it to build. Just unsetting NEEDS_LIBINTL for a platform that doesn't have gettext is curing the symptoms rather than the decease, shouldn't the build system and/or the code be fixed so setting NO_GETTEXT is sufficient instead?

As a side-note, I think it might be time to merge the gettext-branch into msysGit soon. If no one complains, I'll get it done one of the next days.

Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 3 of 12 in “[PULL] ab/i18n rebased on ab/i18n-prereqs”
  1. 000/160 [PULL] ab/i18n rebased on ab/i18n-prereqsÆvar Arnfjörð Bjarmason, Nov 14, 2010
  2. 002/160 Makefile: Set NO_GETTEXT=YesPlease on Windows & MinGWÆvar Arnfjörð Bjarmason, Nov 14, 2010
  3. Erik Faye-LundNov 15, 2010
  4. 003/160 gettext: fix bug in git-sh-i18n's eval_gettext() by using envsubst(1)Ævar Arnfjörð Bjarmason, Nov 14, 2010
  5. Jonathan NiederNov 14, 2010
  6. Junio C HamanoNov 14, 2010
  7. Ævar Arnfjörð BjarmasonNov 14, 2010
  8. Jonathan NiederNov 14, 2010
  9. Ævar Arnfjörð BjarmasonNov 14, 2010
  10. Jonathan NiederNov 14, 2010
  11. Ævar Arnfjörð BjarmasonNov 14, 2010
  12. Ævar Arnfjörð BjarmasonNov 16, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.