Re: [PATCH 003/160] gettext: fix bug in git-sh-i18n's eval_gettext() by using envsubst(1)

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Nov 14, 2010, 21:25 UTC
Message-ID: <AANLkTinh_Nkxvw7Z5HU=TbJHHFRZeWgr0COJ+N96OeTd@mail.gmail.com>
In-Reply-To: <7vmxpb1ztf.fsf@alter.siamese.dyndns.org>

On Sun, Nov 14, 2010 at 20:15, Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> Jonathan Nieder <jrnieder@gmail.com> writes:
>> Nit: can this be moved to a subdir?  Maybe po or i18n, or even
>> envsubst.  This could make it clearer that the code has an upstream
>> and should be updated when upstream is.
>
> IOW, just like "xdiff/" is a separate directory.  I think that is a sane
> thing to do.

Thanks for the suggestion. I'll put it in envsubst/ then.

Any idea about the issue of it being linked to too many things? I tried to add another entry to this section:

    git-%$X: %.o $(GITLIBS)
        $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter
%.o,$^) $(LIBS)

    git-imap-send$X: imap-send.o $(GITLIBS)
        $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
            $(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)

But it wasn't actually used. But then again I don't know Makefile hacking that much.