From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Mon, 15 Nov 2010 10:35:15 GMT
Subject: Re: [PATCH 002/160] Makefile: Set NO_GETTEXT=YesPlease on Windows & MinGW
Message-ID: <AANLkTin2sMUBtS_WgVX39ngRGrWRLf=Z_+UhGNorP6VH@mail.gmail.com>
In-Reply-To: <1289747245-23263-2-git-send-email-avarab@gmail.com>

(msysgit mailing list CC'ed)

On Sun, Nov 14, 2010 at 4:07 PM, Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> Change the Windows and MinGW build defaults to not build the gettext
> tools by default. Gettext hasn't yet been ported to the default
> environments on those systems, although Erik Faye-Lund is working on
> MinGW support.
>
> Reported-by: Johannes Sixt <j6t@kdbg.org>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

I don't think this is exactly what Hannes reported; IIRC he reported
that setting NO_GETTEXT wasn't sufficient to get it to build. Just
unsetting NEEDS_LIBINTL for a platform that doesn't have gettext is
curing the symptoms rather than the decease, shouldn't the build
system and/or the code be fixed so setting NO_GETTEXT is sufficient
instead?

As a side-note, I think it might be time to merge the gettext-branch
into msysGit soon. If no one complains, I'll get it done one of the
next days.