Re: [PATCH 3/3] git-instaweb: Don't assume Apache executable is named apache2

From: Dan McGee <dpmcgee@gmail.com>
Date: Jun 30, 2010, 16:38 UTC
Message-ID: <AANLkTimfy0F7x-WZpfJ0J45jUWjb9lrJt99jY0fO6ZzC@mail.gmail.com>
In-Reply-To: <AANLkTikYNVLM9MrmL819__Viap7ucvmrs7faeC4tdDmn@mail.gmail.com>

On Wed, Jun 30, 2010 at 11:03 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

> Dan McGee <dpmcgee@gmail.com> writes:
>
>> On Arch Linux, we keep the original 'httpd' name for the exectuable and
>> don't rename it or the path to the modules.
>
> Sorry, but I cannot parse the last 6 words here.

On Arch Linux, the executable for the Apache HTTP server keeps the 'httpd' name and is not named 'apache2'. The path to the server modules also contains 'httpd' rather than 'apache2'.

Show 13 quoted lines

>> Remove some of these assumptions
>> and add the httpd name in where it may be required.
>> ...
>>  resolve_full_httpd () {
>>       case "$httpd" in
>> -     *apache2*|*lighttpd*)
>> +     *apache2*|*lighttpd*|*httpd*)
>> +             # yes, *httpd* covers *lighttpd* above, but it is there for clarity
>
> That may make things work better on Arch but I wonder if there are
> platforms that allow users to point at their favorite, non-Apache, http
> server with a canonical name "httpd" that gets broken by this change.  Am
> I being too paranoid?

I think you are being overcautious. Even in this case, you can specify the real name of the web server through git-config or command line parameters to make sure it picks up the right settings. In addition, any web server named 'httpd' wouldn't have worked before anyway so we aren't regressing here. Finally, I've not encountered any platform that does this kind of canonical naming as web servers have very different command line flags and interfaces anyway.

> Other two patches looked very sane.  Thanks.

No problem.

-Dan