Re: [PATCH 1/3] git-instaweb: Fix custom apache log placement

From: Eric Wong <normalperson@yhbt.net>
Date: Jul 22, 2010, 23:42 UTC
Message-ID: <20100722234256.GA19581@dcvr.yhbt.net>
In-Reply-To: <AANLkTiknXtteX77h8Uy1JuWmGLWSSRkAGkS3INMOHBoJ@mail.gmail.com>

Dan McGee <dpmcgee@gmail.com> wrote:

Show 13 quoted lines

> On Tue, Jun 29, 2010 at 9:44 PM, Dan McGee <dpmcgee@gmail.com> wrote:
> > 'CustomLog' is provided by mod_log_config so we need to include the module
> > in our generated config. This was added in d94775e1f9a.
> >
> > Signed-off-by: Dan McGee <dpmcgee@gmail.com>
> 
> I noticed this set of patches didn't go anywhere...at least the first
> two were more bug fixes than improvements so I would have expected
> them to get into 1.7.2. Did they get lost in the shuffle?
> 
> 1: http://marc.info/?l=git&m=127786592330110&w=2
> 2: http://marc.info/?l=git&m=127786592030105&w=2
> 3: http://marc.info/?l=git&m=127791591706076&w=2

Hi Dan, can you address Junio's concerns here?

  http://marc.info/?l=git&m=127791382102449&w=2

Thanks.

-- 
Eric Wong