git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: When to use test_commit (Re: [PATCH] checkout: add a test for creating a new branch with regexp as a starting point)

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jul 30, 2010, 20:20 UTC
Message-ID
<AANLkTimeQA2_fQ_f2pQchbo1coj3=mV9TRPnbET8SQ4F@mail.gmail.com>
In-Reply-To
<20100730191357.GA2448@burratino>
On Fri, Jul 30, 2010 at 19:13, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 6 quoted lines
> Ævar Arnfjörð Bjarmason wrote:
>
>> And actually, we should probably have a
>> test_commit_notag() then.
>
> I don’t know.  What’s so bad about using "git commit" directly?

Nothing, it's just easier to write and read the tests when we have and use functions for these common operations.

Show 10 quoted lines
> I often find myself using "git commit" in tests because test_commit
> imposes all the usual restrictions for a ref name on the commit
> message.  I would happily use an abbreviation for
>
>  test_tick &&
>  git commit -m "something" &&
>  git tag something-else
>
> if available because I don’t like typing, but would that help the
> reader and test runner any?

Maybe just introduce a fourth argument to test_commit, to make it <message> [<file> [<contents> [<tagname>]] instead of <message> [<file> [<contents>]] ?

Previous: Jonathan NiederNext: Dmitry V. Levin
Message 7 of 17 in “checkout: add a test for creating a new branch with regexp as a starting point”
  1. checkout: add a test for creating a new branch with regexp as a starting pointDmitry V. Levin, Jul 29, 2010
  2. Ævar Arnfjörð BjarmasonJul 29, 2010
  3. Thomas RastJul 29, 2010
  4. Dmitry V. LevinJul 30, 2010
  5. Ævar Arnfjörð BjarmasonJul 30, 2010
  6. When to use test_commit (Re: [PATCH] checkout: add a test for creating a new branch with regexp as a starting point)Jonathan Nieder, Jul 30, 2010
  7. Ævar Arnfjörð BjarmasonJul 30, 2010
  8. 1/2 test-lib.sh: introduce 4th argument to test_commit() specifying a tag nameDmitry V. Levin, Jul 31, 2010
  9. Ævar Arnfjörð BjarmasonJul 31, 2010
  10. 1/2 test-lib.sh: introduce 4th argument to test_commit() specifying a tag nameDmitry V. Levin, Jul 31, 2010
  11. Ævar Arnfjörð BjarmasonJul 31, 2010
  12. 2/2 checkout: add a test for creating a new branch with regexp as a starting pointDmitry V. Levin, Jul 31, 2010
  13. Ævar Arnfjörð BjarmasonJul 31, 2010
  14. 2/2 checkout: add a test for creating a new branch with regexp as a starting pointDmitry V. Levin, Jul 31, 2010
  15. Ævar Arnfjörð BjarmasonJul 31, 2010
  16. Dmitry V. LevinAug 5, 2010
  17. Junio C HamanoAug 2, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.