Re: [PATCH] checkout: add a test for creating a new branch with regexp as a starting point

From: Dmitry V. Levin <ldv@altlinux.org>
Date: Jul 30, 2010, 08:44 UTC
Message-ID: <20100730084428.GA9577@wo.int.altlinux.org>
In-Reply-To: <201007300136.13501.trast@student.ethz.ch>

On Thu, Jul 29, 2010 at 11:07:20PM +0000, Ævar Arnfjörð Bjarmason wrote:

> On Thu, Jul 29, 2010 at 22:01, Dmitry V. Levin wrote:

[...]

Show 12 quoted lines

> > +test_expect_success setup '
> > +       echo a > a &&
> > +       git add a &&
> > +       test_tick &&
> > +       git commit -m first &&
> > +       echo b > b &&
> > +       git add b &&
> > +       test_tick &&
> > +       git commit -m second
> > +'
> 
> This should use test_commit (see t/README), but...

The peculiarity of this bug makes it impossible, because test_commit() also creates a tag which spoils test conditions.

Show 10 quoted lines

> > +test_expect_success checkout '
> > +       git checkout -b new_branch :/first
> > +'
> > +
> > +test_done
> 
> ...it looks like this can just be added to the end of
> t2018-checkout-branch.sh instead of creating a new test. Creating a
> new file just for a single test for such a simple feature is a bit of
> an overkill.

Well, I see no t2018-checkout-branch.sh yet. What file do you suggest appending?

On Fri, Jul 30, 2010 at 01:36:13AM +0200, Thomas Rast wrote:

> It should also use test_expect_failure unless you expect to have a fix
> soon, otherwise it would stop the test suite from running through.

Of course I'd like to have this bug fixed, but OK, let it be test_expect_failure() for now.

-- 
ldv