Re: [PATCH] checkout: add a test for creating a new branch with regexp as a starting point

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 30, 2010, 11:54 UTC
Message-ID: <AANLkTikan0hnUa-p-U1dfRKq+bORmrn7A3YTPOPe2N_k@mail.gmail.com>
In-Reply-To: <20100730084428.GA9577@wo.int.altlinux.org>

On Fri, Jul 30, 2010 at 08:44, Dmitry V. Levin <ldv@altlinux.org> wrote:

Show 18 quoted lines

> On Thu, Jul 29, 2010 at 11:07:20PM +0000, Ævar Arnfjörð Bjarmason wrote:
>> On Thu, Jul 29, 2010 at 22:01, Dmitry V. Levin wrote:
> [...]
>> > +test_expect_success setup '
>> > +       echo a > a &&
>> > +       git add a &&
>> > +       test_tick &&
>> > +       git commit -m first &&
>> > +       echo b > b &&
>> > +       git add b &&
>> > +       test_tick &&
>> > +       git commit -m second
>> > +'
>>
>> This should use test_commit (see t/README), but...
>
> The peculiarity of this bug makes it impossible, because test_commit()
> also creates a tag which spoils test conditions.

I didn't know that. It'd be good if the commit message or a comment indicated that. And actually, we should probably have a test_commit_notag() then.

Show 13 quoted lines

>> > +test_expect_success checkout '
>> > +       git checkout -b new_branch :/first
>> > +'
>> > +
>> > +test_done
>>
>> ...it looks like this can just be added to the end of
>> t2018-checkout-branch.sh instead of creating a new test. Creating a
>> new file just for a single test for such a simple feature is a bit of
>> an overkill.
>
> Well, I see no t2018-checkout-branch.sh yet.  What file do you suggest
> appending?

Ah, t2018-checkout-branch.sh only exists on the pu branch, not master/next. It's probably worthwhile to patch it anyway rather than adding a new one.