Re: git svn perl issues

From: Lasse Makholm <lasse.makholm@gmail.com>
Date: Mar 23, 2011, 22:19 UTC
Message-ID: <AANLkTim3yK2=MjO1NbpQ2pu4tV7=hwR-Z9UbixdfAkm=@mail.gmail.com>
In-Reply-To: <521251622.25680.1300916735091.JavaMail.root@tahiti.vyatta.com>

On 23 March 2011 22:45, Stephen Hemminger <stephen.hemminger@vyatta.com> wrote:

Show 15 quoted lines

>
>> On 23 March 2011 16:52, Stephen Hemminger <shemminger@vyatta.com>
>> wrote:
>> > 1. The following needs to be fixed:
>> >
>> > $ git svn clone
>> > Use of uninitialized value $_[0] in substitution (s///) at
>> > /usr/share/perl/5.10.1/File/Basename.pm line 341.
>> > fileparse(): need a valid pathname at /usr/lib/git-core/git-svn line
>> > 403
>>
>> While noisy and ugly, uninitialized warnings are usually pretty
>> harmless...
>
> User should never see perl splat, it is sloppy.

Agreed.

Show 13 quoted lines

>> > 2. The git-svn perl script does not follow Perl Best Practices.
>> > If you run the perlcritic script on it, all the following
>> > warnings/errors
>> > are generated:
>>
>> Some of these are undoubtedly valid complaints, but the so called best
>> practices that the perl critic policies implement are, in my opinion,
>> not widely accepted as such by the perl community. At least not all of
>> them. I wouldn't go following them blindly - especially in working
>> production code...
>
> Some of them are crap, but like sparse warnings it is trivial to
> fix them and make it clean so why not.

Well, personally I don't think they all add any value but that's a bit beside the point here...

> If you don't maintain code it just rots.

True enough. That said, I haven't actually looked into the git-svn code oh my god why do people write 6K line scripts... *sigh*

My first suggestion would be to split it... :-) It's already 75% classes anyway...

[forgot to reply all, sorry for the spam Stephen...]

-- 
/Lasse