Re: git svn perl issues

From: Stephen Hemminger <stephen.hemminger@vyatta.com>
Date: Mar 23, 2011, 21:45 UTC
Message-ID: <521251622.25680.1300916735091.JavaMail.root@tahiti.vyatta.com>
In-Reply-To: <AANLkTikowuFsXFwLL14oS0zzHh3RiHOrGTVHXgyy8dLw@mail.gmail.com>

Show 12 quoted lines

> On 23 March 2011 16:52, Stephen Hemminger <shemminger@vyatta.com>
> wrote:
> > 1. The following needs to be fixed:
> >
> > $ git svn clone
> > Use of uninitialized value $_[0] in substitution (s///) at
> > /usr/share/perl/5.10.1/File/Basename.pm line 341.
> > fileparse(): need a valid pathname at /usr/lib/git-core/git-svn line
> > 403
> 
> While noisy and ugly, uninitialized warnings are usually pretty
> harmless...

User should never see perl splat, it is sloppy.

Show 10 quoted lines

> > 2. The git-svn perl script does not follow Perl Best Practices.
> > If you run the perlcritic script on it, all the following
> > warnings/errors
> > are generated:
> 
> Some of these are undoubtedly valid complaints, but the so called best
> practices that the perl critic policies implement are, in my opinion,
> not widely accepted as such by the perl community. At least not all of
> them. I wouldn't go following them blindly - especially in working
> production code...

Some of them are crap, but like sparse warnings it is trivial to fix them and make it clean so why not.

If you don't maintain code it just rots.