git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git svn perl issues

From
Lasse Makholm <lasse.makholm@gmail.com>
Date
Mar 23, 2011, 21:38 UTC
Message-ID
<AANLkTikowuFsXFwLL14oS0zzHh3RiHOrGTVHXgyy8dLw@mail.gmail.com>
In-Reply-To
<20110323085237.1a52ab7e@nehalam>
On 23 March 2011 16:52, Stephen Hemminger <shemminger@vyatta.com> wrote:
Show 5 quoted lines
> 1. The following needs to be fixed:
>
> $ git svn clone
> Use of uninitialized value $_[0] in substitution (s///) at /usr/share/perl/5.10.1/File/Basename.pm line 341.
> fileparse(): need a valid pathname at /usr/lib/git-core/git-svn line 403
While noisy and ugly, uninitialized warnings are usually pretty harmless...
> 2. The git-svn perl script does not follow Perl Best Practices.
> If you run the perlcritic script on it, all the following warnings/errors
> are generated:

Some of these are undoubtedly valid complaints, but the so called best practices that the perl critic policies implement are, in my opinion, not widely accepted as such by the perl community. At least not all of them. I wouldn't go following them blindly - especially in working production code...

/Lasse
Previous: Stephen HemmingerNext: Stephen Hemminger
Message 2 of 4 in “git svn perl issues”
  1. Stephen HemmingerMar 23, 2011
  2. Lasse MakholmMar 23, 2011
  3. Stephen HemmingerMar 23, 2011
  4. Lasse MakholmMar 23, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.