Re: [PATCH 4/4] builtin: use builtin.h for all builtin commands

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Nov 17, 2010, 20:08 UTC
Message-ID: <AANLkTikw0+FGJmj7C0B9J_3ZVXrbqCw+UzyP3sqfyVdm@mail.gmail.com>
In-Reply-To: <7vzkt7enfn.fsf@alter.siamese.dyndns.org>

On Wed, Nov 17, 2010 at 20:54, Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> Change the builtin/*.c files and wt-status.c files which weren't using
>> builtin.h to use it, also remove any git-compat-util.h, strbuf.h and
>> cache.h from those files. We can trust on builtin.h including them.
>
> As I already said, buitlin/*.c is fine, but wt-status.c is very dubious.

So I should resend this patch with `#include "gettext.h"` in wt-status.c and the rest unchanged, along with a new commit message?

Show 7 quoted lines

>> This impeded my efforts to gettextize git, since I'd otherwise have to
>> add gettext.h to all of these. Using builtin.h is a good idea in any
>> case, since it's defining the prototypes for the cmd_* functions that
>> these files define.
>
> What about non-builtin commands?  Don't they need to include gettext.h
> anyway?

In my patch to add gettext infrastructure I add gettext.h to imap-send.c and friends which have their own main.

> I would have expected that gettext.h would be included from cache.h, so
> that all gitty commands, whether they are builtin or standalone, have
> access to the symbols defined in it.

I can do that too. I just got the impression previously that we wanted to only include things in headers that made sense according to their name. Gettext has nothing to do with the cache, and cache.h itself doesn't need it.

But if we want to stick it in there that's fine by me, I just care about the ends, not the means. So just say which way you want it and I can cook up a patch.