Re: [PATCH 4/4] builtin: use builtin.h for all builtin commands
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Nov 14, 2010, 17:47 UTC
- Message-ID
- <20101114174751.GE26459@burratino>
- In-Reply-To
- <1289745857-16704-5-git-send-email-avarab@gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> This impeded my efforts to gettextize git, since I'd otherwise have to > add gettext.h to all of these. Using builtin.h is a good idea in any > case, since it's defining the prototypes for the cmd_* functions that > these files define.
Yes, I think Junio acked this before, though I can't it in the archive.
Also compare: http://thread.gmane.org/gmane.comp.version-control.git/49523
Show 8 quoted lines
> --- a/wt-status.c > +++ b/wt-status.c > @@ -1,4 +1,4 @@ > -#include "cache.h" > +#include "builtin.h" > #include "wt-status.h" > #include "object.h" > #include "dir.h"
IMHO this deserves a separate mention in the log message. If it is just to get gettext.h, why not include gettext.h directly?