Re: [PATCH 4/4] builtin: use builtin.h for all builtin commands

From

Junio C Hamano <gitster@pobox.com>

Date

Nov 17, 2010, 19:54 UTC

Message-ID

<7vzkt7enfn.fsf@alter.siamese.dyndns.org>

In-Reply-To

<1289745857-16704-5-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Change the builtin/*.c files and wt-status.c files which weren't using
> builtin.h to use it, also remove any git-compat-util.h, strbuf.h and
> cache.h from those files. We can trust on builtin.h including them.

As I already said, buitlin/*.c is fine, but wt-status.c is very dubious.

> This impeded my efforts to gettextize git, since I'd otherwise have to
> add gettext.h to all of these. Using builtin.h is a good idea in any
> case, since it's defining the prototypes for the cmd_* functions that
> these files define.