Re: [PATCH/RFC/WIP/POC] git-gui: grep prototype

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Nov 14, 2010, 22:04 UTC
Message-ID: <AANLkTiktg4aZ7VfdXUT9XF4RK7MuCvzevB5jSRaNiE1L@mail.gmail.com>
In-Reply-To: <20101114215442.GC16413@burratino>

On Sun, Nov 14, 2010 at 22:54, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 23 quoted lines

> Bert Wesarg wrote:
>
>> There is one feature that the upstream git gui lacks[1]: This grep gui can start
>> the git editor on every line by clicking with button 2 in the result area. The
>> git editor will than be started with the environment variable FILENAME and
>> LINENUMBER set but no argument given. This makes it possible to distinguish
>> between normal, blocking edit operation (like git commit) from this
>> open-and-forget type of operation.
>
> This sounds like an excellent sort of thing to add to git grep -O, too
> (which currently has very limited support for editors' line number
> features).  But what will it do with typical non-git-specific setups
> like
>
>        VISUAL=vim
>
> or
>
>        EDITOR="gvim --nofork"
>
> ?
>
> Do existing editors support LINENUMBER in the environment?

I don't expect this, I have a wrapper script around my editor to scan the environment for these variables and pass the block/non-block option to the editor.

Bert