Re: [PATCH/RFC/WIP/POC] git-gui: grep prototype

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Nov 19, 2010, 20:16 UTC
Message-ID: <AANLkTi=-OGvTT+yVqQWUyGn0PmODr=dv1DE9fZkaEDBB@mail.gmail.com>
In-Reply-To: <20101119194907.GG26187@burratino>

On Fri, Nov 19, 2010 at 20:49, Jonathan Nieder <jrnieder@gmail.com> wrote:

> [resending to list; sorry for the noise]

No problem.

Show 12 quoted lines

>
> Bert Wesarg wrote:
>
>> Could we settle on a name space for such variables? GIT_EDITOR_* makes
>> it obvious that it is for the editor started from git.
>
> Sounds good to me.
>
> If the choice of variables ends up looking especially good, maybe
> we can pass it along to the Portland group and call it xdg-editor for
> use by other apps, too. :)
>

Interesting idea.

There is one more thing to discuss before starting collecting the variables. Has each flag its own env-variable, or do we put flags into one variable named GIT_EDITOR_FLAGS? They could be space or comma separated.

The second option sounds a little bit more future prove to me.

For non-flag arguments, there is the obvious LINENUMBER. But how do we pass columns or even a character range to the editor. They would be good for compiler output. Sure its out of score for git, but a little future-thinking will not hurt. We could add it to the LINENUMBER with a syntax like:

    <line>[:<column-start[-<column-end>]]

Bert