Re: [PATCH/RFC/WIP/POC] git-gui: grep prototype

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Nov 14, 2010, 23:48 UTC
Message-ID: <20101114234848.GB26104@burratino>
In-Reply-To: <AANLkTi=JR3vVnZ4Yz8o9MpZKiQ2_ASYxahbPNv8QACir@mail.gmail.com>

Bert Wesarg wrote:

Show 5 quoted lines

> Now I got your point. Maybe I should call GIT_EDITOR with $FILENAME as
> argument but with a new variable to indicate open'n'forget. So
> existing setups would always open the file (even without honoring the
> line number) and new/smart wrappers can honor the open'n'forget and
> line number flag.

Yes, I like the communication-via-environment idea.

In fact, there are multiple questions an editor might want answered:

1. GUI or no GUI?  (The combination of $DISPLAY and $(tty) often
   yields a reasonable answer.)

2. open'n'forget or wait for answer?  (gvim's --nofork option)

3. What line number?

4. regex to use to highlight matches?

Ideally $LINENUMBER would only be used represent (3), while a separate variable would indicate (2).