Re: [msysGit] [PATCH] mingw: do not crash on open(NULL, ...)

From: Pat Thoyts <patthoyts@gmail.com>
Date: Sep 24, 2010, 14:22 UTC
Message-ID: <AANLkTikEvoXuN+vrxry5mz7CM2AuzgBUvUoQxW+zs5oY@mail.gmail.com>
In-Reply-To: <201009232208.56916.j6t@kdbg.org>

On 23 September 2010 21:08, Johannes Sixt <j6t@kdbg.org> wrote:

Show 16 quoted lines

> On Donnerstag, 23. September 2010, Erik Faye-Lund wrote:
>> @@ -297,7 +297,7 @@ int mingw_open (const char *filename, int oflags, ...)
>>       mode = va_arg(args, int);
>>       va_end(args);
>>
>> -     if (!strcmp(filename, "/dev/null"))
>> +     if (filename && !strcmp(filename, "/dev/null"))
>>               filename = "nul";
>>
>>       fd = open(filename, oflags, mode);
>
> Good catch, thank you!
>
> Acked-by: Johannes Sixt <j6t@kdbg.org>
>
> -- Hannes

Applied to devel and pushed.