git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] mingw: do not crash on open(NULL, ...)

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Sep 23, 2010, 17:35 UTC
Message-ID
<1285263325-2016-1-git-send-email-kusmabite@gmail.com>

Since open() already sets errno correctly for the NULL-case, let's just avoid the problematic strcmp.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
 compat/mingw.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/compat/mingw.c b/compat/mingw.c
index b0ad919..b408c3c 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -297,7 +297,7 @@ int mingw_open (const char *filename, int oflags, ...)
 	mode = va_arg(args, int);
 	va_end(args);
 
-	if (!strcmp(filename, "/dev/null"))
+	if (filename && !strcmp(filename, "/dev/null"))
 		filename = "nul";
 
 	fd = open(filename, oflags, mode);
-- 
1.7.2.3.msysgit.0.207.gda0b3
Next: Erik Faye-Lund
Message 1 of 12 in “mingw: do not crash on open(NULL, ...)”
  1. mingw: do not crash on open(NULL, ...)Erik Faye-Lund, Sep 23, 2010
  2. Erik Faye-LundSep 23, 2010
  3. Pat ThoytsSep 23, 2010
  4. Erik Faye-LundSep 23, 2010
  5. Junio C HamanoSep 23, 2010
  6. Erik Faye-LundSep 27, 2010
  7. Pat ThoytsSep 27, 2010
  8. Erik Faye-LundSep 27, 2010
  9. Johannes SchindelinSep 27, 2010
  10. Johannes SchindelinSep 24, 2010
  11. Johannes SixtSep 23, 2010
  12. Pat ThoytsSep 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.