Re: [msysGit] [PATCH] mingw: do not crash on open(NULL, ...)

From: Johannes Sixt <j6t@kdbg.org>
Date: Sep 23, 2010, 20:08 UTC
Message-ID: <201009232208.56916.j6t@kdbg.org>
In-Reply-To: <1285263325-2016-1-git-send-email-kusmabite@gmail.com>

On Donnerstag, 23. September 2010, Erik Faye-Lund wrote:

Show 9 quoted lines

> @@ -297,7 +297,7 @@ int mingw_open (const char *filename, int oflags, ...)
>  	mode = va_arg(args, int);
>  	va_end(args);
>
> -	if (!strcmp(filename, "/dev/null"))
> +	if (filename && !strcmp(filename, "/dev/null"))
>  		filename = "nul";
>
>  	fd = open(filename, oflags, mode);

Good catch, thank you!

Acked-by: Johannes Sixt <j6t@kdbg.org>

-- Hannes