Re: [PATCHv2 1/7] CodingGuidelines: mention whitespace preferences for shell scripts
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Dec 3, 2010, 22:02 UTC
- Message-ID
- <AANLkTi=PmGR23AMog4UWQVNKPWrDUM_kYWV_Bn1vvSwE@mail.gmail.com>
- In-Reply-To
- <7vsjyemt1f.fsf@alter.siamese.dyndns.org>
On Fri, Dec 3, 2010 at 10:43 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 25 quoted lines
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes: > >> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com> >> --- >> Documentation/CodingGuidelines | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines >> index 5aa2d34..a9191d0 100644 >> --- a/Documentation/CodingGuidelines >> +++ b/Documentation/CodingGuidelines >> @@ -31,6 +31,10 @@ But if you must have a list of rules, here they are. >> >> For shell scripts specifically (not exhaustive): >> >> + - We use tabs for indentation. >> + >> + - Case arms are not indented with respect to the case and esac lines. > > Thanks. > I am tempted to rephrase the latter as: > > Case arms are indented at the same depth as case and esac lines. > > It makes it less hard to read and understand without negation.
Good idea. I'll rephrase in that sense and add a couple more entries about the | spacing and long case arm splitting, for the next rehash of the series.
-- Giuseppe "Oblomov" Bilotta