Re: [PATCHv2 1/7] CodingGuidelines: mention whitespace preferences for shell scripts

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 3, 2010, 21:43 UTC
Message-ID: <7vsjyemt1f.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1291394861-11989-2-git-send-email-giuseppe.bilotta@gmail.com>

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:

Show 16 quoted lines

> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> ---
>  Documentation/CodingGuidelines |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
> index 5aa2d34..a9191d0 100644
> --- a/Documentation/CodingGuidelines
> +++ b/Documentation/CodingGuidelines
> @@ -31,6 +31,10 @@ But if you must have a list of rules, here they are.
>  
>  For shell scripts specifically (not exhaustive):
>  
> + - We use tabs for indentation.
> +
> + - Case arms are not indented with respect to the case and esac lines.

Thanks. I am tempted to rephrase the latter as:

    Case arms are indented at the same depth as case and esac lines.

It makes it less hard to read and understand without negation.