Re: [PATCHv2 7/7] web--browse: look at the BROWSER env var
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Dec 3, 2010, 17:16 UTC
- Message-ID
- <20101203171628.GA13721@burratino>
- In-Reply-To
- <20101203170800.GE12910@burratino>
Jonathan Nieder wrote:
> Giuseppe Bilotta wrote:
Show 12 quoted lines
>> --- a/git-web--browse.sh >> +++ b/git-web--browse.sh >> @@ -138,6 +138,51 @@ then >[...] >> +if test -z "$browser" -a -n "$BROWSER"; then >> + OLDIFS="$IFS" >> + IFS=: >[...] >> + IFS="$OLDIFS" > > Micronit: on some shells (e.g., old ash[1]), IFS starts out unset if > it hasn't been inherited in the environment.
Of course, we are using this idiom in a few places already, so that can be saved for another topic. Sorry for not checking sooner.