Re: [PATCH] Remove "bashism" from contrib/thunderbird-patch-inline/appp.sh

From: Maxin john <maxin@maxinbjohn.info>
Date: Mar 29, 2011, 06:47 UTC
Message-ID: <AANLkTi=Nd897+GrfmPS38aQo_Vh-J9cJr9bB-UzN_CqQ@mail.gmail.com>
In-Reply-To: <7v7hbiviwv.fsf@alter.siamese.dyndns.org>

Hi,

> It is better to explain the patch as
>
>  Subject: contrib/thunderbird-patch-inline: do not require /bin/bash to run

Yes. I do agree with you. I should have chosen a better Subject line for this patch. Should I resend this patch with this modified Subject line ?

Thanks and Regards, Maxin B. John

On Tue, Mar 29, 2011 at 4:01 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> Maxin john <maxin@maxinbjohn.info> writes:
>
>> Remove "bashism" and minor corrections for
>> contrib/thunderbird-patch-inline/appp.sh
>
> The script seems to only use standard POSIX shell features and nothing
> particularly bash specific nor outside POSIX in general that we exclude
> from our coding standards (e.g. "local", use of "function" noiseword,
> substring expansion ${parmeter:offset:length}).
>
> It is better to explain the patch as
>
>  Subject: contrib/thunderbird-patch-inline: do not require /bin/bash to run
>
>