Re: [PATCH] Remove "bashism" from contrib/thunderbird-patch-inline/appp.sh

From

ÁGÁngel González <ingenit@zoho.com>

Date

Mar 28, 2011, 21:55 UTC

Message-ID

<4D9103D3.5010403@zoho.com>

In-Reply-To

<AANLkTin-USDnTxeKT_KOZW5kgC0vFXYbMNP9ct6fzbUC@mail.gmail.com>

Maxin john wrote:

> Remove "bashism" and minor corrections for
> contrib/thunderbird-patch-inline/appp.sh
> 
> Signed-off-by: Maxin B. John <maxin@maxinbjohn.info>

This is wrong.

You are replacing bash with sh:

> -#!/bin/bash
> +#!/bin/sh

but the script still uses bash-specific syntax (aka. bashishms):

> +
>  PATCH=$(zenity --file-selection)
> 
>  if [ "$?" != "0" ] ; then