git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Remove "bashism" from contrib/thunderbird-patch-inline/appp.sh

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 30, 2011, 17:57 UTC
Message-ID
<7vmxkco5jg.fsf@alter.siamese.dyndns.org>
In-Reply-To
<AANLkTim+0gxGKZT=vfmX7v0QZrApjRwAzW3PiLePL-iQ@mail.gmail.com>
Maxin john <maxin@maxinbjohn.info> writes:
> So, I have modified the patch by incorporating most of the nice suggestions.

I'd just replace /bin/bash with /bin/sh without any other fuss, perhaps except for the typofix in the comment, and be done with the topic.

The script in the current version may look ugly to my eyes and others, but there is nothing _wrong_ in it per-se. Rewriting them in different styles is not necessarily improvement, and this is only a contrib/ material after all.

Thanks, I'll apply the early hunks from you.
Previous: Maxin johnNext: Maxin john
Message 7 of 13 in “Remove "bashism" from contrib/thunderbird-patch-inline/appp.sh”
  1. Remove "bashism" from contrib/thunderbird-patch-inline/appp.shMaxin john, Mar 27, 2011
  2. Ángel GonzálezMar 28, 2011
  3. Maxin johnMar 29, 2011
  4. Junio C HamanoMar 29, 2011
  5. Ángel GonzálezMar 29, 2011
  6. Maxin johnMar 30, 2011
  7. Junio C HamanoMar 30, 2011
  8. Maxin johnMar 30, 2011
  9. Junio C HamanoMar 31, 2011
  10. Ángel GonzálezMar 29, 2011
  11. Junio C HamanoMar 29, 2011
  12. Maxin johnMar 29, 2011
  13. Victor EngmarkMar 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.