Re: [PATCHv5 10/12] gitweb: git_repo_url() routine
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Sep 27, 2010, 07:29 UTC
- Message-ID
- <AANLkTi=N-TRCHFRo5G8oXUDoe3H_Xv+BTpvc9PwjM6Pu@mail.gmail.com>
- In-Reply-To
- <201009270034.29603.jnareb@gmail.com>
2010/9/27 Jakub Narebski <jnareb@gmail.com>:
Show 12 quoted lines
> On Fri, 24 Sep 2010, Giuseppe Bilotta wrote:
>
>> The routine creates a table row with a name and a repository address,
>> like the one used at the top of summary view.
> [...]
>
>> +sub git_repo_url {
>> + my ($name, $url) = @_;
>> + return "<tr class=\"metadata_url\"><td>$name</td><td>$url</td></tr>\n";
>> +}
>
> It should be *format_repo_url*, and not git_repo_url, isn't it?Right.
> By the way, doesn't gitweb include code dealing with repository URL; > why you don't _use_ this subroutine, then?
The only code for the display of a repo URL is inlined into summary view, which in the next patch uses this function to do the display. I can probably squash them together.
-- Giuseppe "Oblomov" Bilotta