Re: [PATCHv5 01/12] gitweb: introduce remote_heads feature

From: Jakub Narebski <jnareb@gmail.com>
Date: Sep 26, 2010, 17:24 UTC
Message-ID: <201009261924.06237.jnareb@gmail.com>
In-Reply-To: <1285344167-8518-2-git-send-email-giuseppe.bilotta@gmail.com>

On Fri, 24 Sep 2010, Giuseppe Bilotta wrote:

Show 7 quoted lines

> With this feature enabled, remotes are retrieved (and displayed)
> when getting (and displaying) the heads list. Typical usage would be for
> local repository browsing, e.g. by using git-instaweb (or even a more
> permanent gitweb setup), to check the repository status and the relation
> between tracking branches and the originating remotes.
> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>

Nice and straighforward.  For what it is worth:

Acked-by: Jakub Narebski <jnareb@gmail.com>

Show 14 quoted lines

> ---
>  gitweb/gitweb.perl |   18 ++++++++++++++++--
>  1 files changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index a85e2f6..f09fcee 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -486,6 +486,18 @@ our %feature = (
>  		'sub' => sub { feature_bool('highlight', @_) },
>  		'override' => 0,
>  		'default' => [0]},
> +
> +	# Make gitweb show remotes too in the heads list

Very minor nitpick: it should probably be (but I am not a native English speaker, so I migh be mistaken)

  +	# Make gitweb show also remotes in the heads list

Show 10 quoted lines

> +
> +	# To enable system wide have in $GITWEB_CONFIG
> +	# $feature{'remote_heads'}{'default'} = [1];
> +	# To have project specific config enable override in $GITWEB_CONFIG
> +	# $feature{'remote_heads'}{'override'} = 1;
> +	# and in project config gitweb.remote_heads = 0|1;
> +	'remote_heads' => {
> +		'sub' => sub { feature_bool('remote_heads', @_) },
> +		'override' => 0,
> +		'default' => [0]},

[...]

-- 
Jakub Narebski
Poland