Re: [PATCHv5 02/12] gitweb: git_get_heads_list accepts an optional list of refs.
On Fri, 24 Sep 2010, Giuseppe Bilotta wrote:
> git_get_heads_list(limit, class1, class2, ...) can now be used to retrieve
> refs/class1, refs/class2 etc. Defaults to ('heads') or ('heads', 'remotes')
> depending on the remote_heads option.Possible (very minor) nitpick:
s/on remote_heads option/on 'remote_heads' feature/
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Very nice extension of an API. Good work. FWIW
Acked-by: Jakub Narebski <jnareb@gmail.com>
Show 35 quoted lines
> ---
> gitweb/gitweb.perl | 11 +++++++----
> 1 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index f09fcee..27c455e 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -3155,15 +3155,18 @@ sub parse_from_to_diffinfo {
> ## parse to array of hashes functions
>
> sub git_get_heads_list {
> - my $limit = shift;
> + my ($limit, @classes) = @_;
> + unless (defined @classes) {
> + my $remote_heads = gitweb_check_feature('remote_heads');
> + @classes = ('heads', $remote_heads ? 'remotes' : ());
> + }
> + my @patterns = map { "refs/$_" } @classes;
> my @headslist;
>
> - my $remote_heads = gitweb_check_feature('remote_heads');
> -
> open my $fd, '-|', git_cmd(), 'for-each-ref',
> ($limit ? '--count='.($limit+1) : ()), '--sort=-committerdate',
> '--format=%(objectname) %(refname) %(subject)%00%(committer)',
> - 'refs/heads', ($remote_heads ? 'refs/remotes' : ())
> + @patterns
> or return;
> while (my $line = <$fd>) {
> my %ref_item;
> --
> 1.7.3.68.g6ec8
>
> --
Jakub Narebski
Poland
Jakub Narebski <jnareb@gmail.com>