RE: Git sideband hook output

From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Date: Jun 9, 2010, 08:04 UTC
Message-ID: <A612847CFE53224C91B23E3A5B48BAC744839BF3DD@xmail3.se.axis.com>
In-Reply-To: <20100608214632.GN14847@spearce.org>

Show 24 quoted lines

> -----Original Message-----
> From: git-owner@vger.kernel.org [mailto:git-owner@vger.kernel.org] On
> Behalf Of Shawn O. Pearce
> Sent: den 8 juni 2010 23:47
> To: Scott Chacon
> Cc: git list
> Subject: Re: Git sideband hook output
> 
> Scott Chacon <schacon@gmail.com> wrote:
> > Prior to 6d525d where Shawn made the receive-pack process send hook
> > output over side band #2, how did the hook output get sent to the
> > client?
> 
> It was sent over stderr, which was proxied down to the client by
> the SSH daemon.
> 
> > On older clients (before this commit) and on older servers,
> > the hook output just shows up without the 'remote:' prefix.
> 
> Because its echoed to the tty by the SSH client, without Git ever
> seeing it.
> 
> > After
> > this commit I get the 'remote:' prefix,

This explains the messy output from hooks I have seen since updating to 1.7.1...

Show 7 quoted lines

> Now its being parsed out of the stream by the git client, using
> the same code that displays the progress messages during clone/fetch.
> 
> > which is kind of annoying.
> 
> Depends on your perspective.  Its nice to know that the messages
> came from the server, rather than from your client.  :-)

And it is very annoying that the output format has suddenly changed so that the output from hooks that rely on the previous no-prefix format no longer fit on an 80 char wide terminal where they used to fit just fine.

Show 7 quoted lines

> > Is
> > there a way to suppress this to get the old output format?
> 
> No.  Other than to have the hook not output anything at all.
> 
> --
> Shawn.

Here is +1 for giving us back the no-prefix output. I would like to suggest adding a configuration option to allow users to enable the "remote: " prefix if they want it.

//Peter