git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Silence iconv warnings on Leopard

From
Blake Ramsdell <blaker@gmail.com>
Date
Dec 6, 2007, 23:04 UTC
Message-ID
<985966520712061504s686395d6jf680363c7b3b9de7@mail.gmail.com>
In-Reply-To
<1196968023-45284-1-git-send-email-win@wincent.com>
On Dec 6, 2007 11:07 AM, Wincent Colaiuta <win@wincent.com> wrote:
Show 5 quoted lines
> Apple ships a newer version of iconv with Leopard (Mac OS X 10.5/Darwin
> 9). Ensure that OLD_ICONV is not set on any version of Darwin in the
> 9.x series; this should be good for at least a couple of years, when
> Darwin 10 comes out and we can invert the sense of the test to
> specifically check for Darwin 7 or 8.

This approach seems fine to me, there was some concern about matching the OS type / version in the past, but I haven't really seen a better answer.

> A more sophisticated and robust check is possible for those who use
> autoconf, but not everybody does that.

I did make a patch for configure.ac that does this. If it's interesting, I'll send it along.

Blake
-- 
Blake Ramsdell | http://www.blakeramsdell.com
Previous: Wincent ColaiutaNext: Jakub Narebski
Message 2 of 12 in “Silence iconv warnings on Leopard”
  1. Silence iconv warnings on LeopardWincent Colaiuta, Dec 6, 2007
  2. Blake RamsdellDec 6, 2007
  3. Jakub NarebskiDec 7, 2007
  4. Blake RamsdellDec 7, 2007
  5. Linus TorvaldsDec 7, 2007
  6. Blake RamsdellDec 7, 2007
  7. Blake RamsdellDec 7, 2007
  8. autoconf: Add test for OLD_ICONV (squelching compiler warning)Jakub Narebski, Dec 7, 2007
  9. Junio C HamanoDec 7, 2007
  10. Wincent ColaiutaDec 7, 2007
  11. Wincent ColaiutaDec 7, 2007
  12. Blake RamsdellDec 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.